feat: added server variable object as reusable object #717
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
danielkocot
changed the title
Co-authored-by: Maciej Urbańczyk <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
For me it looks good 🚀 We have first feature to 2.4.0!
I'm not a maintainer of that repo, so I cannot accept it 😅 cc @derberg @fmvilas
You should be also interest @smoya @jonaslagoni
|
LGTM so far 👍 The only thing I'm missing now is the PRs on the https://github.com/asyncapi/spec-json-schemas and https://github.com/asyncapi/parser-js/ repos. |
|
Can anybody help me with the PR for the https://github.com/asyncapi/parser-js/ repo? |
|
@danielkocot Sure! You should write needed method for new field in this class https://github.com/asyncapi/parser-js/blob/master/lib/models/components.js like |
|
Last missing PR: asyncapi/parser-js#476 |
|
@danielkocot please have a look at examples. You propose |
|
@derberg Check again :) They are inside |
|
ah 😅 servers were also under components 😄 sorry folks 🍺 |
|
EDIT: NVM! better to wait first #736 to be merged. Then I will ping you again. Thanks. |
|
@danielkocot #736 has been merged. Would you mind changing the base branch to |
danielkocot
requested review from
fmvilas,
derberg,
dalelane and
asyncapi-bot-eve
as code owners
Co-authored-by: Dale Lane <[email protected]>
sadly it is. Co-authored-by: Dale Lane <[email protected]>
|
@derberg can you approve the workflows so they can run? Thanks
|
|
@fmvilas as per your comment, it looks OK to you. Would you mind checking again now that all PR's have been created? |
There was a problem hiding this comment.
@danielkocot there is only one little thing to fix here and we will be most probably ready to merge it soon 🚀
Co-authored-by: Sergio Moya <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
derberg
added
🏁 Accepted (RFC 3)
|
done, main issue has it already too |
|
All PR's have been merged. Proceeding with this PR. |
|
/rtm |
|
🎉 This PR is included in version 2.4.0-2022-04-release.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
title: "Server Variable Object as reusable object"
Related issue(s):
#707
The PR targets to have Server Variable Objects as reusable objects within the Component Object.