Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let channels be identified by ID. Address is now moved into a new field #171

Closed
wants to merge 1 commit into from

Conversation

smoya
Copy link
Member

@smoya smoya commented Feb 9, 2022

This PR allows channels to be identified by an ID rather than by their address. Instead, the address has now been moved into a new field called address.

This is a breaking change so it should be considered as a candidate for v3.0.0.

Related issue(s):

See asyncapi/spec#663 for knowing about the reason behind this RFC.

CC @char0n @magicmatatjahu @derberg

@smoya smoya changed the title feat: let channels be identified by ID. Address is now moved into a n… feat: let channels be identified by ID. Address is now moved into a new field Feb 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 10, 2022
@smoya
Copy link
Member Author

smoya commented Jun 10, 2022

@fmvilas @derberg would you mind removing the stale label?

@smoya smoya marked this pull request as draft June 10, 2022 10:00
@smoya smoya marked this pull request as ready for review June 10, 2022 10:01
@fmvilas fmvilas removed the stale label Jun 10, 2022
@jonaslagoni
Copy link
Member

jonaslagoni commented Jul 18, 2022

@smoya if you switch branch you can convert this to the new definitions 🙂

@smoya smoya changed the base branch from master to next-major-spec July 19, 2022 16:04
@smoya
Copy link
Member Author

smoya commented Jul 19, 2022

@smoya if you switch branch you can convert this to the new definitions 🙂

Yeah, thanks. Now is done. The reality is that maintaining a change in a new JSON Schema file (3.0) for a long time (major version) is hard since other versions will happen in the meantime. Keeping the new schema up to date is a manual and hard task.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@smoya
Copy link
Member Author

smoya commented Sep 30, 2022

Closing in favour of #264

@smoya smoya closed this Sep 30, 2022
@smoya smoya deleted the feat/channelID branch September 30, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants