-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: let channels be identified by ID. Address is now moved into a new field #171
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
@smoya if you switch branch you can convert this to the new definitions 🙂 |
Yeah, thanks. Now is done. The reality is that maintaining a change in a new JSON Schema file (3.0) for a long time (major version) is hard since other versions will happen in the meantime. Keeping the new schema up to date is a manual and hard task. |
Kudos, SonarCloud Quality Gate passed! |
Closing in favour of #264 |
This PR allows channels to be identified by an ID rather than by their address. Instead, the address has now been moved into a new field called
address
.This is a breaking change so it should be considered as a candidate for
v3.0.0
.Related issue(s):
See asyncapi/spec#663 for knowing about the reason behind this RFC.
CC @char0n @magicmatatjahu @derberg