Merge branch 'master' into test/definitions

asyncapi · Jun 13, 2024 · b260532 · b260532
2 parents 291f066 + d83cc02
commit b260532
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/.github/workflows/if-nodejs-pr-testing.yml b/.github/workflows/if-nodejs-pr-testing.yml
@@ -14,7 +14,9 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        # Using macos-13 instead of latest (macos-14) due to an issue with Puppeteer and such runner. 
+        # See: https://github.com/puppeteer/puppeteer/issues/12327 and https://github.com/asyncapi/parser-js/issues/1001
+        os: [ubuntu-latest, macos-13, windows-latest]
     steps:
       - if: >
           !github.event.pull_request.draft && !(

diff --git a/.github/workflows/if-nodejs-release.yml b/.github/workflows/if-nodejs-release.yml
@@ -33,7 +33,9 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        # Using macos-13 instead of latest (macos-14) due to an issue with Puppeteer and such runner. 
+        # See: https://github.com/puppeteer/puppeteer/issues/12327 and https://github.com/asyncapi/parser-js/issues/1001
+        os: [ubuntu-latest, macos-13, windows-latest]
     steps:
       - name: Set git to use LF #to once and for all finish neverending fight between Unix and Windows
         run: |

diff --git a/.github/workflows/issues-prs-notifications.yml b/.github/workflows/issues-prs-notifications.yml
@@ -20,8 +20,6 @@ jobs:
     name: Notify slack on every new issue
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v3
       - name: Convert markdown to slack markdown for issue
         uses: asyncapi/.github/.github/actions/slackify-markdown@master
         id: issuemarkdown
@@ -40,8 +38,6 @@ jobs:
     name: Notify slack on every new pull request
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v3
       - name: Convert markdown to slack markdown for pull request
         uses: asyncapi/.github/.github/actions/slackify-markdown@master
         id: prmarkdown
@@ -60,8 +56,6 @@ jobs:
     name: Notify slack on every new pull request
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v3
       - name: Convert markdown to slack markdown for pull request
         uses: asyncapi/.github/.github/actions/slackify-markdown@master
         id: discussionmarkdown