Skip to content

Commit

Permalink
fix: update script, update package.json
Browse files Browse the repository at this point in the history
Changes:

- Revert 'if-nodejs-pr-testing.yml' to original condition.

- Update 'package.json', changed "test" field to include the JSON Schema validation.

- Change naming convention, from 'validate-schema' to 'validate:schema'.

- Modify error handling 'catch' block on line 79 to terminate script if
  the schema is not valid.

- Applied suggestion from: #452 (review)
  • Loading branch information
AnimeshKumar923 committed Dec 12, 2023
1 parent 3cbe26d commit aeada06
Show file tree
Hide file tree
Showing 4 changed files with 1,290 additions and 3,285 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/if-nodejs-pr-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,4 @@ jobs:
run: npm run lint --if-present
- if: steps.packagejson.outputs.exists == 'true'
name: Run release assets generation to make sure PR does not break it
run: npm run generate:assets --if-present
- if: steps.packagejson.outputs.exists == 'true'
name: Run JSON Schema Validator
run: npm run validate-schemas
run: npm run generate:assets --if-present
Loading

0 comments on commit aeada06

Please sign in to comment.