-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#200 implement dotnet best practises #201
base: main
Are you sure you want to change the base?
#200 implement dotnet best practises #201
Conversation
a8e61ef
to
01c2907
Compare
01c2907
to
90aba96
Compare
I will definitely accept this request when we resolve the issues with the code style and architecture) |
Hi, i ready to merge this. @thompson-tomo will you resolve conflict? |
Sure will do so in the next couple of days |
9da5647
to
4df2567
Compare
4df2567
to
99aed45
Compare
@yurvon-screamo sorry for the delay, find merges resolved. Note i am guessing the large diff is due to the editor config now being run on the csproj files etc |
in - name: Run NPM install
shell: sh
run: npm ci
working-directory: ./src/Saunter.UI to: - name: Create package-lock
shell: sh
run: npm install --package-lock-only
working-directory: ./src/Saunter.UI
- name: Run NPM install
shell: sh
run: npm ci
working-directory: ./src/Saunter.UI |
Description
Reason for the change
Lays the foundation for future changes in particular package splitting.
Related issue(s)
Closes #200