Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#200 implement dotnet best practises #201

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

thompson-tomo
Copy link

@thompson-tomo thompson-tomo commented Apr 21, 2024

Description

  • Move to central package management
  • Use central properties to prepare for split
  • Move to csproj internalvisibleto rather than assemblyinfo.cs

Reason for the change
Lays the foundation for future changes in particular package splitting.

Related issue(s)
Closes #200

@thompson-tomo thompson-tomo changed the title Chore/#200 standardisation #200 implement dotnet best practises Apr 21, 2024
@yurvon-screamo yurvon-screamo marked this pull request as draft April 22, 2024 12:49
@thompson-tomo thompson-tomo force-pushed the chore/#200_Standardisation branch from a8e61ef to 01c2907 Compare April 22, 2024 22:09
@thompson-tomo thompson-tomo marked this pull request as ready for review April 22, 2024 22:10
@thompson-tomo thompson-tomo force-pushed the chore/#200_Standardisation branch from 01c2907 to 90aba96 Compare May 21, 2024 10:16
@yurvon-screamo
Copy link
Collaborator

I will definitely accept this request when we resolve the issues with the code style and architecture)

@yurvon-screamo
Copy link
Collaborator

Hi, i ready to merge this. @thompson-tomo will you resolve conflict?

@thompson-tomo
Copy link
Author

Sure will do so in the next couple of days

@thompson-tomo thompson-tomo force-pushed the chore/#200_Standardisation branch 5 times, most recently from 9da5647 to 4df2567 Compare October 27, 2024 04:58
@thompson-tomo thompson-tomo force-pushed the chore/#200_Standardisation branch from 4df2567 to 99aed45 Compare October 27, 2024 05:02
@thompson-tomo
Copy link
Author

@yurvon-screamo sorry for the delay, find merges resolved. Note i am guessing the large diff is due to the editor config now being run on the csproj files etc

@yurvon-screamo
Copy link
Collaborator

in .github/npm/action.yaml try change, maybe it will help:

    - name: Run NPM install
      shell: sh
      run: npm ci
      working-directory: ./src/Saunter.UI

to:

    - name: Create package-lock
      shell: sh
      run: npm install --package-lock-only
      working-directory: ./src/Saunter.UI
    - name: Run NPM install
      shell: sh
      run: npm ci
      working-directory: ./src/Saunter.UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement more dotnet best practises
2 participants