Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable release workflow #165

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

derberg
Copy link
Member

@derberg derberg commented Jan 18, 2023

Resolves #151

What I did:

  • made proper npm package name
  • cleanup scripts and dependencies for release (basically no deps are now needed)

@emilianozublena before we merge it, please:

My recommendation is:

Thoughts?

@emilianozublena
Copy link
Member

hihi @derberg ! looking good.
Not sure if you saw my comment here: #151 (comment) but i don't see the regular name update field under settings, maybe i'm lacking some permission or am i just looking at the wrong place?. Already added the topics, and will create the release after i manage to change the name.

I think we should also remove the node tests as there's nothing to be run there yet, right?

Thanks a ton!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member Author

derberg commented Jan 20, 2023

@emilianozublena

  • sorry, I missed comment on permissions issue, now you are admin and should see rename
  • I removed test script for now. Now CI fails because of linter but I see you fix it in another PR, so we can just ignore here, especially that for now testing workflow is not mandatory. But, after first release probably should, to at least validate linter errors

@emilianozublena
Copy link
Member

Awesome @derberg! just changed the name and here's the release dummy version
https://github.com/asyncapi/php-template/releases/tag/v0.0.1

@emilianozublena
Copy link
Member

hihi @derberg any news with this? i know you're onto a lot, but don't want to forget about it.

@derberg
Copy link
Member Author

derberg commented Jan 31, 2023

sorry @emilianozublena 😞 was out a bit to charge batteries.

you could merge. Best do it through comment like 👇🏼

/rtm (which stands for ready-to-merge)

@asyncapi-bot asyncapi-bot merged commit d23e09f into asyncapi:master Jan 31, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting this template released
3 participants