Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: new trait behaviour in v3 spec #744

Merged
merged 7 commits into from
Jul 20, 2023
Merged

chore: new trait behaviour in v3 spec #744

merged 7 commits into from
Jul 20, 2023

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Apr 2, 2023 •
edited by smoya
Loading

Description

Related issue(s)
#744
Part of asyncapi/spec#907
Fixes #810

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Apr 2, 2023
@magicmatatjahu magicmatatjahu changed the title chore: new trait behaviour chore: new trait behaviour in v3 spec Apr 2, 2023
@magicmatatjahu magicmatatjahu mentioned this pull request Apr 2, 2023
Merged
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni mentioned this pull request Apr 26, 2023
Closed
@smoya smoya self-requested a review as a code owner June 30, 2023 10:06
@smoya
Copy link
Member

smoya commented Jun 30, 2023

I'm taking over this fixing what is failing so we can move forward

@smoya smoya force-pushed the next-spec/new-trait branch from 39708b2 to 71681ea Compare June 30, 2023 13:58
@smoya
Copy link
Member

smoya commented Jun 30, 2023

Tests fail because after updating the branch with the changes from next-major-spec, the code expects to have a newer version of @asyncapi/specs that supports the new schema exports structure (split in schemas and schemasWithoutId). See https://github.com/asyncapi/spec-json-schemas/blob/master/index.js.

Changing the code to support an old version of that package is not an option since we will be doing the work twice.

asyncapi/spec-json-schemas#406 is needed to be merged and released in order to unblock this PR.

cc @fmvilas @jonaslagoni @magicmatatjahu

@smoya smoya mentioned this pull request Jul 18, 2023
Closed
4 tasks
@smoya smoya mentioned this pull request Jul 20, 2023
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@smoya
Copy link
Member

smoya commented Jul 20, 2023

@fmvilas @jonaslagoni @magicmatatjahu all is fixed now, ready to review! 🙏

fmvilas
fmvilas approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@magicmatatjahu
Copy link
Member Author

LGTM! I cannot accept my PR :) Thanks for handling that @smoya! ❤️

@smoya
Copy link
Member

smoya commented Jul 20, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 2000140 into asyncapi:next-major-spec Jul 20, 2023
@magicmatatjahu magicmatatjahu deleted the next-spec/new-trait branch July 20, 2023 13:46
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-next-major-spec.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@derberg derberg Awaiting requested review from derberg

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready-to-merge released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magicmatatjahu @smoya @asyncapi-bot @fmvilas