Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release branch #426

Merged
merged 4 commits into from
Dec 27, 2021

Conversation

dalelane
Copy link
Contributor

  • add mime types for new asyncapi version
  • update release branch name in package.json

Contributes to: asyncapi/spec#675

Signed-off-by: Dale Lane [email protected]

@dalelane dalelane mentioned this pull request Dec 14, 2021
39 tasks
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fmvilas have a look

@derberg derberg requested a review from fmvilas December 21, 2021 14:29
Comment on lines 47 to 58
'application/vnd.aai.asyncapi;version=2.0.0',
'application/vnd.aai.asyncapi;version=2.1.0',
'application/vnd.aai.asyncapi;version=2.2.0',
'application/vnd.aai.asyncapi;version=2.3.0',
'application/vnd.aai.asyncapi+json;version=2.0.0',
'application/vnd.aai.asyncapi+json;version=2.1.0',
'application/vnd.aai.asyncapi+json;version=2.2.0',
'application/vnd.aai.asyncapi+json;version=2.3.0',
'application/vnd.aai.asyncapi+yaml;version=2.0.0',
'application/vnd.aai.asyncapi+yaml;version=2.1.0',
'application/vnd.aai.asyncapi+yaml;version=2.2.0',
'application/vnd.aai.asyncapi+yaml;version=2.3.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I'm already wondering if we should refactor this to something like:

Suggested change
'application/vnd.aai.asyncapi;version=2.0.0',
'application/vnd.aai.asyncapi;version=2.1.0',
'application/vnd.aai.asyncapi;version=2.2.0',
'application/vnd.aai.asyncapi;version=2.3.0',
'application/vnd.aai.asyncapi+json;version=2.0.0',
'application/vnd.aai.asyncapi+json;version=2.1.0',
'application/vnd.aai.asyncapi+json;version=2.2.0',
'application/vnd.aai.asyncapi+json;version=2.3.0',
'application/vnd.aai.asyncapi+yaml;version=2.0.0',
'application/vnd.aai.asyncapi+yaml;version=2.1.0',
'application/vnd.aai.asyncapi+yaml;version=2.2.0',
'application/vnd.aai.asyncapi+yaml;version=2.3.0',
...['2.0.0', '2.1.0', '2.2.0', '2.3.0'].map((version) => {
[
`application/vnd.aai.asyncapi;version=${version}`,
`application/vnd.aai.asyncapi+json;version=${version}`,
`application/vnd.aai.asyncapi+yaml;version=${version}`,
]
}).flat()

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmvilas Definitely makes sense as then it is just a matter of adding new version to the list once, no copy/paste.

Just small improvement, missing return and generic mime types:

function getMimeTypes() {
  return [
    ...['2.0.0', '2.1.0', '2.2.0', '2.3.0'].map((version) => {
      return [
        `application/vnd.aai.asyncapi;version=${version}`,
        `application/vnd.aai.asyncapi+json;version=${version}`,
        `application/vnd.aai.asyncapi+yaml;version=${version}`,
      ]
    }).flat().concat(['application/schema;version=draft-07', 'application/schema+json;version=draft-07', 'application/schema+yaml;version=draft-07'])
  ];
}

@derberg derberg requested a review from fmvilas December 27, 2021 10:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

1 similar comment
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
Copy link
Member

derberg commented Dec 27, 2021

@fmvilas updated, you can approve

@dalelane I'm not sure about your availability now between Christmas and new year so took liberty to improve PR directly 😉

@derberg
Copy link
Member

derberg commented Dec 27, 2021

/rtm

@asyncapi-bot asyncapi-bot merged commit dcf8d46 into asyncapi:2022-01-release Dec 27, 2021
@dalelane dalelane deleted the 2022-01-release branch December 27, 2021 20:57
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.0-2022-01-release.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants