Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate if server security has security schema and is valid #115

Merged
merged 5 commits into from
Jul 16, 2020
Merged

feat: validate if server security has security schema and is valid #115

merged 5 commits into from
Jul 16, 2020

Conversation

derberg
Copy link
Member

@derberg derberg commented Jul 10, 2020 •
edited
Loading

Description

  • checking if server security key maps to a corresponding security schema in components
  • checking if server security values is an empty array in cases when schema type is not oauth2 or openIdConnect
  • location finder now supports arrays, like servers.{server}.security

Related issue(s)
Resolves #10

@derberg derberg requested a review from fmvilas July 11, 2020 11:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg merged commit ec8969a into asyncapi:master Jul 16, 2020
@derberg derberg deleted the secschema branch July 16, 2020 08:44
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List down manual validations
3 participants
@derberg @asyncapi-bot @fmvilas