-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added loading animation in output #2042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alokih does not seem to work, at least we still see the old generated models with no loading screen when changing input and options.
Please make sure you test the preview that Netlify creates 🙂
ok @jonaslagoni , I'll try to do it |
Pull Request Test Coverage Report for Build 9530098031Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When changing options, why we see blank on output side, instead we need loading...
animation. Also you can notice that the loading...
apears after the code is updated.
2024-06-23.01-47-28.mp4
Closing as no progress, feel free to re-open if you get back to it @Alokih |
Description
Added a loading... message in output, if there is any change in input field or other general options
Related Issue
Fixes: #1725
Checklist
npm run lint
).npm run test
).