Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add devilkiller-ag as codeowner #1647

Merged
merged 2 commits into from
Dec 19, 2023
Merged

chore: add devilkiller-ag as codeowner #1647

merged 2 commits into from
Dec 19, 2023

Conversation

jonaslagoni
Copy link
Member

Description
With his latest work on the playground: #1628

I am suggesting we add @devilkiller-ag as a codeowner for the website 💪

cc @kennethaasan @magicmatatjahu @Ferror @leigh-johnson @Samridhi-98 any objections?

Lazy consensus will be used with @devilkiller-ag acceptance after 1 week from this PR creation 🙂

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit c2d7b7d
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65813c0e36e9a50008c77d05

@coveralls
Copy link

coveralls commented Dec 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7258340456

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.516%
Totals Coverage Status
Change from base Build 7200933275: 0.0%
Covered Lines: 5600
Relevant Lines: 5901
💛 - Coveralls

@jonaslagoni
Copy link
Member Author

@devilkiller-ag please approve the PR (or decline ;)) if you want to become a codeowner and take on that responsibility 🙂

@devilkiller-ag
Copy link
Member

Hi @jonaslagoni, I accept to be the code owner of the Modelina Website. However, I am not getting an option for approving this PR.

@jonaslagoni
Copy link
Member Author

@devilkiller-ag if you go into files changed you should see a review button 🙂

@devilkiller-ag
Copy link
Member

devilkiller-ag commented Dec 11, 2023 •
edited
Loading

Oh got it 😁. I thought I had to Approve the PR Merge.😅

leigh-johnson
leigh-johnson approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@leigh-johnson leigh-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome @devilkiller-ag

@jonaslagoni
Copy link
Member Author

Welcome again @devilkiller-ag 🎉

@jonaslagoni jonaslagoni merged commit 2c055ec into master Dec 19, 2023
24 of 26 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jonaslagoni jonaslagoni deleted the add-devilkiller-ag-codeowner branch December 19, 2023 06:46
@devilkiller-ag
Copy link
Member

Welcome again @devilkiller-ag 🎉

Thanks @jonaslagoni 😊

@jonaslagoni
Copy link
Member Author

@devilkiller-ag you can now add yourself to the AsyncAPI TSC incase you are interested ✌️

Follow the same approach as here: asyncapi/community#971

@devilkiller-ag
Copy link
Member

@devilkiller-ag you can now add yourself to the AsyncAPI TSC incase you are interested ✌️

Follow the same approach as here: asyncapi/community#971

Sure, I will do this today✨

@kennethaasan
Copy link
Collaborator

Welcome!

Harshil-Jani pushed a commit to Harshil-Jani/modelina that referenced this pull request Dec 19, 2023
@jonaslagoni @Harshil-Jani
chore: add devilkiller-ag as codeowner (asyncapi#1647)
a6b524d
@devilkiller-ag devilkiller-ag mentioned this pull request Dec 19, 2023
Merged
@devilkiller-ag
Copy link
Member

Welcome!

Thanks @kennethaasan ✨

@derberg
Copy link
Member

derberg commented Dec 19, 2023

@jonaslagoni kind reminder that you need to invite @devilkiller-ag as maintainer to this repo, otherwise GitHub will not respect his approvals

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Dec 19, 2023 •
edited
Loading

🤦 Completely forgot thanks @derberg, @devilkiller-ag check your email, you should have received the invite 🙂

@devilkiller-ag
Copy link
Member

Thanks @jonaslagoni, I accepted the invite.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samridhi-98 Samridhi-98 Samridhi-98 approved these changes

@devilkiller-ag devilkiller-ag devilkiller-ag approved these changes

@Ferror Ferror Ferror approved these changes

@leigh-johnson leigh-johnson leigh-johnson approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jonaslagoni @coveralls @devilkiller-ag @kennethaasan @derberg @asyncapi-bot @leigh-johnson @Ferror @Samridhi-98