Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 2.4.0 #45

Merged
merged 61 commits into from
Dec 18, 2023
Merged

feat: 2.4.0 #45

merged 61 commits into from
Dec 18, 2023

Conversation

Pakisan
Copy link
Member

@Pakisan Pakisan commented Dec 15, 2023

  • AsyncAPI 3.0.0
  • Compatibility with IDEA 2023.3

Pakisan added 30 commits December 6, 2023 21:21
@Pakisan
build: gradle-intellij-plugin 1.15.0 -> 1.16.1
e9773f5
@Pakisan
build: intellij-plugin-verifier 1.303 -> 1.307
7062608
@Pakisan
build: intellij-plugin-verifier add new 2023.2 versions
7a45c5f
@Pakisan
feat: IDEA 2023.3
0c1c56b
@Pakisan
Merge branch 'master' into release/2.4.0
6027c75
@Pakisan
feat: AsyncAPI 3.0.0 JsonSchema
b37e20d
@Pakisan
feat: create AsyncAPI 3.0.0 specification from template
affd9e4
@Pakisan
fix: validation tests - channels case
f1b6336 
In 2023.3 internal format for linter error was changed
@Pakisan
Merge branch 'master' into release/2.4.0
fdcd14d
@Pakisan
Merge branch 'release/2.4.0' into feat/asyncapi-3.0.0
477698a
@Pakisan
refactor: rename AsyncAPISchemaHtmlRenderer to AsyncAPISpecificationH…
b534033 
…tmlRenderer
@Pakisan
refactor: rename AsyncAPISchemaCompletionContributor to AsyncAPISpeci…
1e48dff 
…ficationCompletionContributor
@Pakisan
refactor: rename AsyncAPISchemaRecognizer to AsyncAPISpecificationRec…
87eb11d 
…ognizer
@Pakisan
refactor: rename AsyncAPISpecificationRecognizer isSchema to isSpecif…
6960dae 
…ication
@Pakisan
feat: AsyncAPI 3.0.0 completion
77f4916
@Pakisan
test: 3.0.0 AsyncAPISpecificationRecognizerTest
fcce095
@Pakisan
test: 3.0.0 AsyncAPIJsonSchemaProviderTest
1f7a088
@Pakisan
refactor: rename AsyncAPISpecificationRecognizerTest method names
da89423
@Pakisan
refactor: rename AsyncAPISchemaReferenceContributor to AsyncAPISpecif…
f1d06e0 
…icationReferenceContributor
@Pakisan
refactor: rename AsyncAPISchemaReferencesCollector to AsyncAPISpecifi…
e51a8d6 
…cationReferencesCollector
@Pakisan
refactor: AsyncAPISpecificationReferencesCollector move from _core to…
46e1bb3 
… extensions.index
@Pakisan
refactor: rename AsyncAPISchemaIndex to AsyncAPISpecificationIndex
c5cd3c2
@Pakisan
refactor: rename AsyncAPISchemaIndexer to AsyncAPISpecificationIndexer
7c9625e
@Pakisan
refactor: rename AsyncAPISchemaDetector to AsyncAPISpecificationDetector
1f0d9b3
@Pakisan
refactor: move v2 index to v2 package
701f87a
@Pakisan
refactor: rename AsyncAPISpecificationDetector isAsyncAPISchema to is…
8718b3d 
…AsyncAPISpecification
@Pakisan
refactor: rename AsyncAPISpecificationDetector isReferencedAsyncAPISc…
878611c 
…hema to isAsyncAPISpecificationComponent
@Pakisan
refactor: rename and make private AsyncAPISpecificationDetector#isRef…
f384a87 
…erencedAsyncAPIJsonSchema to isAsyncAPISpecificationJsonComponent
@Pakisan
refactor: rename and make private AsyncAPISpecificationDetector#isRef…
7c9d2fb 
…erencedAsyncAPIYamlSchema to isAsyncAPISpecificationYamlComponent
@Pakisan
refactor: rename AsyncAPISpecificationDetector#indexedAsyncAPISchemas…
547e3f3 
… to indexedAsyncAPISpecifications
@Pakisan Pakisan self-assigned this Dec 15, 2023
philCryoport
philCryoport requested changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@philCryoport philCryoport left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Far too much to review with my limited time. See comments above.

Next time you're going to do a wholesale object renaming, PLEASE...for love of everything is holy
...DON'T combine that wholesale object renaming with a AsyncAPI specification version update!?!
...AND DON'T combine that with a IntelliJ version roll!?!

build.gradle.kts Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
@philCryoport
Copy link
Collaborator

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@Pakisan I suggest resolving this code-quality-gate.

Then I'll approve the PR

@Pakisan
fix(inspection description): sonar issues
0b59e9c 
Changed to <p> instead of whole html

- Insert a <!DOCTYPE> declaration to before this <html> tag.
- Add "lang" and/or "xml:lang" attributes to this "<html>" element
- Add a <title> tag to this page.

reference: https://plugins.jetbrains.com/docs/intellij/code-inspections.html#inspection-description
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@Pakisan
Copy link
Member Author

Pakisan commented Dec 18, 2023

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@Pakisan I suggest resolving this code-quality-gate.

Then I'll approve the PR

Done

@Pakisan
Copy link
Member Author

Pakisan commented Dec 18, 2023

Will update kotlin version after IDEA 2023.3.2 release.

Now I'm working on https://github.com/asyncapi/jasyncapi. Folks from Specmatic are waiting for new release with spec v3

@philCryoport
Copy link
Collaborator

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@Pakisan I suggest resolving this code-quality-gate.
Then I'll approve the PR

Done

Thank you! Just to be safe, I'm running the plugin verifier...

philCryoport
philCryoport approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@philCryoport philCryoport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With note that Kotlin JVM version will be updated in a separate PR.

Successful clean / buildPlugin / runPluginVerifier.

theschles
theschles approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@theschles theschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is same person as @philCryoport -- that's my current work account, this is my personal account.

@Pakisan Pakisan merged commit 73c2df3 into master Dec 18, 2023
7 checks passed
@Pakisan Pakisan deleted the release/2.4.0 branch December 18, 2023 19:54
@Pakisan Pakisan restored the release/2.4.0 branch December 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philCryoport philCryoport philCryoport approved these changes

@theschles theschles theschles approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

@Pakisan Pakisan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pakisan @philCryoport @theschles