Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: glee docs automation workflow #548

Merged

Conversation

AnimeshKumar923
Copy link
Contributor

@AnimeshKumar923 AnimeshKumar923 commented Oct 20, 2023

Description

This PR adds the necessary workflows required to automate the process of updating Glee docs in the main website.

Related issue(s)

Fixes #481

Changes:

- Made the changes to be in accordance of the glee repository.
- Can be modified later according to the feedbacks.
@Souvikns
Copy link
Member

@afzal442 can you please review this once?

@afzal442
Copy link
Contributor

afzal442 commented Oct 25, 2023

Thanks @Souvikns for that. But I am not sure on it. Look likes @derberg has reviewed such a gh action workflow before. 😄 sorry @derberg can you approve it if it meets the workflow required for this event?

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 2 comments, hope that helps

.github/workflows/update-docs-on-docs-commits.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,50 @@
name: Update latest Glee documentation in the website
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the workflow and script looks good.

but did anyone try to first check manually if this is enough? Website docs will not just digest what you send that easily out of the box. I quickly looked into your docs dir and noticed:

My recommendation, try to do the same that you do here in the workflow, manually on a website, and see if your docs will render. I would suggest a prerequisite for this PR is to have a draft PR on website that showcases that after merging this PR it will work like a charm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I will be doing this part. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afzal442 Thanks! 👍 🚀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have no front matters in markdown files

sorry @derberg I forgot to tell you about that is you could find those on /docs/pages/* folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moreover, this PR is up to migrate those remaining pages to /pages/ folder. Hope that makes sense now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folks, you can now add get-global-docs-autoupdate topic to this repo, and ask @KhudaDad414 to run https://github.com/asyncapi/.github/actions/workflows/global-replicator.yml against this repo

AnimeshKumar923 and others added 2 commits October 31, 2023 23:18
Changes:

- add suggestion from asyncapi#548 (comment)

Co-authored-by: Afzal Ansari <[email protected]>
Changes:

- deleted this workflow because as told by Lukasz because it will be centrally managed in .github repo by asyncapi/.github#242
Copy link
Contributor

@afzal442 afzal442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side. 🚀 ... left it to maintainers.

@AnimeshKumar923
Copy link
Contributor Author

LGTM from my side. 🚀 ... left it to maintainers.

Thank you! 🙏

KhudaDad414
KhudaDad414 previously approved these changes Nov 1, 2023
.github/workflows/update-docs-in-website.yml Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@KhudaDad414
Copy link
Member

thanks for the contribution @AnimeshKumar923 and @afzal442 . I am merging this PR now.

@KhudaDad414 KhudaDad414 changed the title feat: glee docs automation workflow ci: glee docs automation workflow Nov 1, 2023
@AnimeshKumar923
Copy link
Contributor Author

thanks for the contribution @AnimeshKumar923 and @afzal442 . I am merging this PR now.

@KhudaDad414 Happy to help! 😁

@KhudaDad414
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 25ab916 into asyncapi:master Nov 1, 2023
15 checks passed
@AnimeshKumar923 AnimeshKumar923 deleted the docs-automation-workflow branch November 1, 2023 13:46
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.28.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create GitHub Action to Render Docs into AsyncAPI Website Pages
6 participants