-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: glee docs automation workflow #548
ci: glee docs automation workflow #548
Conversation
Changes: - Made the changes to be in accordance of the glee repository. - Can be modified later according to the feedbacks.
@afzal442 can you please review this once? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left 2 comments, hope that helps
@@ -0,0 +1,50 @@ | |||
name: Update latest Glee documentation in the website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the workflow and script looks good.
but did anyone try to first check manually if this is enough? Website docs will not just digest what you send that easily out of the box. I quickly looked into your docs
dir and noticed:
- you have subfolders
- you have no front matters in markdown files, like title/weights in https://github.com/asyncapi/cli/blob/master/docs/context.md
My recommendation, try to do the same that you do here in the workflow, manually on a website, and see if your docs will render. I would suggest a prerequisite for this PR is to have a draft PR on website that showcases that after merging this PR it will work like a charm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I will be doing this part. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afzal442 Thanks! 👍 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have no front matters in markdown files
sorry @derberg I forgot to tell you about that is you could find those on /docs/pages/*
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moreover, this PR is up to migrate those remaining pages to /pages/
folder. Hope that makes sense now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
folks, you can now add get-global-docs-autoupdate
topic to this repo, and ask @KhudaDad414 to run https://github.com/asyncapi/.github/actions/workflows/global-replicator.yml against this repo
Changes: - add suggestion from asyncapi#548 (comment) Co-authored-by: Afzal Ansari <[email protected]>
Changes: - deleted this workflow because as told by Lukasz because it will be centrally managed in .github repo by asyncapi/.github#242
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side. 🚀 ... left it to maintainers.
Thank you! 🙏 |
Kudos, SonarCloud Quality Gate passed! |
thanks for the contribution @AnimeshKumar923 and @afzal442 . I am merging this PR now. |
@KhudaDad414 Happy to help! 😁 |
/rtm |
🎉 This PR is included in version 0.28.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR adds the necessary workflows required to automate the process of updating Glee docs in the main website.
Related issue(s)
Fixes #481