Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove fail test #398

Merged
merged 4 commits into from
Jul 22, 2024
Merged

ci: remove fail test #398

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e91888
ci: remove fail test
Shurtu-gal Jul 20, 2024
0159638
Merge remote-tracking branch 'upstream/master' into ci/update
Shurtu-gal Jul 20, 2024
9ff67b0
fix: bump test and fixtures
Shurtu-gal Jul 20, 2024
0d6077a
chore: update bundle command
Shurtu-gal Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export GITHUB_WORKSPACE = $(shell pwd)
run:
@bash ./entrypoint.sh $(DEFAULT_VERSION) $(DEFAULT_COMMAND) $(TEST_FILEPATH) $(DEFAULT_TEMPLATE) $(DEFAULT_LANGUAGE) $(DEFAULT_OUTPUT) $(DEFAULT_PARAMETERS) $(DEFAULT_CUSTOM_COMMANDS)

test: test-default test-validate-success test-validate-fail test-custom-output test-custom-commands test-optimize test-bundle test-convert test-action-bump
test: test-default test-validate-success test-custom-output test-custom-commands test-optimize test-bundle test-convert test-action-bump

# Test cases

Expand Down Expand Up @@ -51,7 +51,7 @@ test-optimize:
@bash ./entrypoint.sh $(DEFAULT_VERSION) 'optimize' 'test/unoptimized.yml' $(DEFAULT_TEMPLATE) $(DEFAULT_LANGUAGE) $(DEFAULT_OUTPUT) '-o new-file --no-tty' $(DEFAULT_CUSTOM_COMMANDS)

# Tests if the action can bundle the specification with custom commands
BUNDLE_COMMAND='bundle ./test/bundle/asyncapi.yaml ./test/bundle/features.yaml --base ./test/bundle/asyncapi.yaml --reference-into-components -o ./output/bundle/asyncapi.yaml'
BUNDLE_COMMAND='bundle ./test/bundle/asyncapi.yaml ./test/bundle/features.yaml --base ./test/bundle/asyncapi.yaml -o ./output/bundle/asyncapi.yaml'
test-bundle:
mkdir -p ./output/bundle
@bash ./entrypoint.sh $(DEFAULT_VERSION) 'bundle' 'test/bundle/asyncapi.yaml' $(DEFAULT_TEMPLATE) $(DEFAULT_LANGUAGE) $(DEFAULT_OUTPUT) '-o output/bundle/asyncapi.yaml' $(BUNDLE_COMMAND)
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ runs:
using: 'docker'
# This is the image that will be used to run the action.
# IMPORTANT: The version has to be changed manually in your PRs.
image: 'docker://asyncapi/github-action-for-cli:3.1.1'
image: 'docker://asyncapi/github-action-for-cli:3.1.2'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg could you please check if the bump is correct ( always get confused regarding this 😢 ).

args:
- ${{ inputs.cli_version }}
- ${{ inputs.command }}
Expand Down
2 changes: 1 addition & 1 deletion bump-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ echo "Package version: $version";
if [[ $action_version > $version ]]; then
echo "Action version is greater than package version";
else \
echo "Action version has not been bumped. Please bump the action version to the semantically correct version after $$version"; \
echo "Action version has not been bumped. Please bump the action version to the semantically correct version after $version"; \
exit 1; \
fi
4 changes: 2 additions & 2 deletions test/bundle/features.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ info:
description: This service is in charge of processing user logouts
channels:
user/loggedOut:
subcribe:
subscribe:
message:
$ref: 'test/bundle/messages.yaml#/messages/UserLoggedOut'
$ref: "./test/bundle/messages.yaml#/messages/UserLoggedOut"
Loading