Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy non-JS files in the React templates by default #472

Merged
merged 6 commits into from
Jan 5, 2021
Merged

fix: copy non-JS files in the React templates by default #472

merged 6 commits into from
Jan 5, 2021

Conversation

magicmatatjahu
Copy link
Member

Description

As in title: copy all non-JS files in the React render engine by default. Problem is described in the #466 issue:

At the moment the Generator in the React case doesn't copy non-JS files in template, but skipped them. Workaround is add files to nonRenderableFiles array in configuration of template in package.json, but for template like https://github.com/asyncapi/nodejs-template/tree/master/template it isn't cool and has big impact to development: Each non-JS file must be added manually to an array.

Also if someone doesn't want render some .js file then can include it inside nonRenderableFiles array.

Related issue(s)
Resolves #466

@magicmatatjahu magicmatatjahu added the bug Something isn't working label Jan 4, 2021
derberg
derberg requested changes Jan 4, 2021
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, just few questions

lib/generator.js Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Show resolved Hide resolved
derberg
derberg previously approved these changes Jan 5, 2021
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu magicmatatjahu merged commit 1c8ded0 into asyncapi:master Jan 5, 2021
@magicmatatjahu magicmatatjahu deleted the 466-copy-all-non-js-files-react branch January 5, 2021 09:09
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy non-JS files in the React render engine
3 participants
@magicmatatjahu @asyncapi-bot @derberg