-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: jsdoc return statement update #1330
Conversation
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was fast
can you specify why you didn't add these https://github.com/asyncapi/generator/pull/967/files#diff-ccc178369ef3ad89acc2592970d94838d2dc83c38731610f3675be2ee3e6f99aR216-R226. How can I learn from JSDoc the structure of TemplateRenderResult
if this is not provided? or maybe should the type be imported from react sdk dependency?
Hehe Thank you : )
We don't need to import or declare the type generator/apps/generator/lib/generator.js Line 926 in 59504bc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
I changed PR title, as fix
indicates release and we do not need to release new artefact for this one. Anyway fix:
is not enough if changeset is not provided
/rtm |
No, worries Thank you for your approval. I'll open a PR for updating website with repo too. |
this part is automated: asyncapi/website#3573 |
Fantastic 🔥 |
Description
Updating return statements of functions
generateFromString
,generateFromURL
andgenerateFromFile
by adding typeTemplateRenderResult | undefined
Related issue(s)
Fixes: #507
Screenshot of markdown rendered on website:
cc: @derberg @ItshMoh