-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add meta/open graph tags #71
Conversation
✔️ Deploy Preview for peaceful-ramanujan-288045 ready! 🔨 Explore the source changes: 571884e 🔍 Inspect the deploy log: https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/61843d23b39d1e0007621d6c 😎 Browse the preview: https://deploy-preview-71--peaceful-ramanujan-288045.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@mcturco that was fast! how was it with PUG 😄 All is good except of the image. Look at Slack and Twitter: docs say:
try this in PUG config. URL is env variable that is populated by Netlify during the build, so it will work on production and previews too, no need to hardcode
|
@derberg okay yup! I just noticed the same thing and fixed it! It was just the image path that wasn't nearly correct once it passes through netlify :) you can see the preview here: https://www.opengraph.xyz/url/https%3A%2F%2Fdeploy-preview-71--peaceful-ramanujan-288045.netlify.app%2F/ |
It was honestly not terrible! But probably would take some getting used to. I'm used to writing HTML the normal way, although with emmet abbreviations its not too bad 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, so the docs lie and you can actually have a relative path, interesting
anyway, just made one suggestion so we do not hardcode the URL of the conference website (as it will later turn into conference.2021.asyncapi.com and we forget to change)
Co-authored-by: Lukasz Gornicki <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
I think it is due to Netlify deploying it. It must fill in the blanks for us 😄
Good idea, thank you! Committed that in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect work 🚀
Thank you so much 🍺
Description
Related issue(s)
Resolves #57