Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ticket section render issue #445

Closed
wants to merge 14 commits into from

Conversation

toffee-k21
Copy link
Contributor

Description

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for peaceful-ramanujan-288045 failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit e383aa6
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67455a9baf8d5a0008918278

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)

@toffee-k21
Copy link
Contributor Author

@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)

Hey @AceTheCreator, I've updated the Ticket section to show upcoming events first, followed by events ended. This functionality was already implemented

@AceTheCreator
Copy link
Member

@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)

Hey @AceTheCreator, I've updated the Ticket section to show upcoming events first, followed by events ended. This functionality was already implemented

But i think cards shouldn't have background

@toffee-k21
Copy link
Contributor Author

But i think cards shouldn't have background

Hey @AceTheCreator , I have removed the background as you mentioned

@ashmit-coder
Copy link
Collaborator

ashmit-coder commented Nov 2, 2024

But i think cards shouldn't have background

Hey @AceTheCreator , I have removed the background as you mentioned

Looks great @toffee-k21 .
But don't you think the items in the second row shoud start from the middle? (The london UK ticket card)
cc: @AceTheCreator

@toffee-k21
Copy link
Contributor Author

Looks great @toffee-k21 . But don't you think the items in the second row shoud start from the middle? (The london UK ticket card) cc: @AceTheCreator

@AceTheCreator, I have fixed the alignment and made the cards align in the middle

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toffee-k21 i think it'll look visually appealing if the list of tickets is rendered in a carousel layout. wyt?

@toffee-k21
Copy link
Contributor Author

@toffee-k21 i think it'll look visually appealing if the list of tickets is rendered in a carousel layout. wyt?

Great idea! Displaying tickets in this way will keep the layout compact, conserving vertical space and this will also improve readability

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toffee-k21 why are you not using the slider component we already have in code?

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please demonstrate with a video how the component would look when the carousal effect is been applied.

@toffee-k21
Copy link
Contributor Author

@toffee-k21 why are you not using the slider component we already have in code?

Hey @AceTheCreator @ashmit-coder, I've implemented the card render section using the slider component. Let me know if there's anything you'd like to change!

@toffee-k21 toffee-k21 closed this Nov 26, 2024
@toffee-k21
Copy link
Contributor Author

Could you please demonstrate with a video how the component would look when the carousal effect is been applied.

I have raised a new PR #478 that will resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the way the ticket section is being rendered
3 participants