Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add docs community section to onboarding guide #959

Merged
merged 9 commits into from
Jan 20, 2024
Merged

docs: add docs community section to onboarding guide #959

merged 9 commits into from
Jan 20, 2024

Conversation

remigathoni
Copy link
Contributor

Description

Added the docs community section for the onboarding guide.

github-actions[bot]
github-actions bot reviewed Nov 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@quetzalliwrites quetzalliwrites changed the title docs: Add Docs community section to onboarding guide docs: add docs community section to onboarding guide Nov 28, 2023
@quetzalliwrites quetzalliwrites marked this pull request as ready for review November 28, 2023 01:18
@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Nov 28, 2023
quetzalliwrites
quetzalliwrites requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first draft, Mary! Thank you ☺️ ❤️

Left some feedback and commit suggestions for you.

@remigathoni @quetzalliwrites
docs: apply suggestions from review
b330b42 
Co-authored-by: Alejandra Quetzalli  <[email protected]>
@remigathoni
Copy link
Contributor Author

Great first draft, Mary! Thank you ☺️ ❤️

Left some feedback and commit suggestions for you.

Just checked your suggestions!
Looks like I need to be more specific as I write! I'll remember that.
Thank you for the feedback☺️

quetzalliwrites
quetzalliwrites previously approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your work, @remigathoni!

I fixed some items, please take time to read my draft rewrite to learn how to improve your own writing ❤️ . Look forward to working with you again!

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 4969344 into asyncapi:master Jan 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@quetzalliwrites quetzalliwrites quetzalliwrites approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@thulieblack thulieblack Awaiting requested review from thulieblack thulieblack is a code owner

Assignees
No one assigned
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs ready-to-merge
Projects
AsyncAPI Docs Board
Status: Community PR under Review 🧐
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remigathoni @quetzalliwrites @asyncapi-bot