-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto schedule youtube stream #851
feat: auto schedule youtube stream #851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudoshreyansh thanks a 💯
left 2 comments
I will need your guidance on how to create a proper tokens in google cloud + what needs to be added to secrets
@sudoshreyansh hey, you need help? |
@derberg 👋, made the changes. Please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added few comments
also, please share tips on how to properly create token and secret in google, to make sure it works :D
@@ -70,6 +70,10 @@ on: | |||
required: true | |||
TWITTER_ACCESS_TOKEN_SECRET: | |||
required: true | |||
GOOGLE_OAUTH_TOKEN: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need to update all the workflows that start with create-event
, like https://github.com/asyncapi/community/blob/master/.github/workflows/create-event-lets-talk-about.yml
you need to pass these 2 additional google secrets
/** | ||
* Schedules a live stream with the parameters provided. | ||
* | ||
* @param {String} title Title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update jsdoc please
with: | ||
script: | | ||
const { scheduleLivestream } = require('./.github/workflows/create-event-helpers/youtube/index.js'); | ||
scheduleLivestream('${{ inputs.date }}T${{ inputs.time }}:00Z', 'PLbi1gRlP7pijUwZJErzyYf_Rc-PWu4lXS'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
playlist id cannot be hardcoded here as there are different playlists per meeting
we need to be able to use it this way that for example in https://github.com/asyncapi/community/blob/master/.github/workflows/create-event-lets-talk-about.yml
I can do:
with:
yt_playlist: PLbi1gRlP7pigPBrBMaNQhUeniR1pdDMiY
so here you need
scheduleLivestream('${{ inputs.date }}T${{ inputs.time }}:00Z', 'PLbi1gRlP7pijUwZJErzyYf_Rc-PWu4lXS'); | |
scheduleLivestream('${{ inputs.date }}T${{ inputs.time }}:00Z', '${{ inputs.yt_playlist }}'); |
@sudoshreyansh ping pong 🙏🏼 |
@derberg made the changes. Could you give them a look again? |
yo @sudoshreyansh so sorry mate for super later followup but AsyncAPI v3 took over us last several weeks
Please 🙏🏼 |
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Description