Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update package @asyncapi/bundler to version 0.6.1 #1492

Merged

Conversation

aeworxet
Copy link
Contributor

@aeworxet aeworxet commented Aug 7, 2024

This PR updates the @asyncapi/bundler package to version 0.6.0.

@Shurtu-gal
Copy link
Collaborator

@aeworxet the tests are currently not passing.

@aeworxet
Copy link
Contributor Author

aeworxet commented Aug 8, 2024

Bundler v0.6.0 uses structuredClone(), which was added only in Node 17.

Should it be stated in CLI's documentation that the minimal version of Node.js is v18 or is it too early to make users upgrade to v18 and I should rewrite Bundler's functionality with a polyfill or without structuredClone() at all (good ol' JSON.parse(JSON.stringify())) (downgrade?)

@aeworxet aeworxet force-pushed the fix-update-bundler-to-version-0.6.0 branch from 937f820 to ab299dc Compare August 8, 2024 03:21
@Souvikns
Copy link
Member

Souvikns commented Aug 8, 2024

Well according to the website v20 is the current LTS version, but still v16 is still wildly used so I think we should still support v16 for some time in the near future.

@aeworxet
Copy link
Contributor Author

aeworxet commented Aug 8, 2024

Replaced in Bundler native structuredClone() with a polyfill to keep compatibility with Node.js v16.

I will update this PR as soon as asyncapi/bundler#183 is merged and Bundler v0.6.1 is released.

@aeworxet aeworxet changed the title fix: update package @asyncapi/bundler to version 0.6.0 fix: update package @asyncapi/bundler to version 0.6.1 Aug 8, 2024
Copy link

sonarqubecloud bot commented Aug 8, 2024

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeworxet
Copy link
Contributor Author

aeworxet commented Aug 8, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 494bbfb into asyncapi:master Aug 8, 2024
11 checks passed
@aeworxet aeworxet deleted the fix-update-bundler-to-version-0.6.0 branch August 8, 2024 08:35
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants