Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create new command for the react template #1476

Merged
merged 12 commits into from
Jul 12, 2024
Merged

feat: create new command for the react template #1476

merged 12 commits into from
Jul 12, 2024

Conversation

AayushSaini101
Copy link
Contributor

@AayushSaini101 AayushSaini101 commented Jul 1, 2024 •
edited
Loading

Resolves: #337

@AayushSaini101 AayushSaini101 marked this pull request as draft July 1, 2024 12:24
@AayushSaini101 AayushSaini101 marked this pull request as ready for review July 4, 2024 10:20
Amzani
Amzani requested changes Jul 5, 2024
View reviewed changes
assets/create-template/templates/default/asyncapi.yaml Outdated
@@ -0,0 +1,33 @@
asyncapi: 2.6.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AayushSaini101 I suggest to target version 3 instead, as we want people to adopt it.

assets/create-template/templates/default/package.json Outdated
"supportedProtocols": [ ]
},
"dependencies": {
"@asyncapi/generator-react-sdk": "^0.2.25"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to pick last version of generator-react-sdk
https://github.com/asyncapi/generator-react-sdk/releases/tag/v1.0.20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @Amzani

assets/create-template/templates/default/template/package.json.js Outdated
@@ -0,0 +1,21 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the naming of this file and its purpose

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed thanks @Amzani

src/core/flags/new/template.flags.ts
import { Flags } from '@oclif/core';

export const templateFlags = () => {
return {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add also renderer flag as some people may use nunjucks, see: https://www.asyncapi.com/docs/tools/generator/template-development

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @Amzani

@AayushSaini101 AayushSaini101 requested a review from Amzani July 8, 2024 11:48
@Amzani
Copy link
Collaborator

Amzani commented Jul 9, 2024

Let's wait for other maintainers review as well @Shurtu-gal @Souvikns

Souvikns
Souvikns approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Shurtu-gal
Shurtu-gal approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AayushSaini101
Copy link
Contributor Author

@Amzani Please review

Amzani
Amzani approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AayushSaini101
Copy link
Contributor Author

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @AayushSaini101! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: To request an update from the upstream branch, simply comment /u or /update and our bot will handle the update operation promptly.

       The only requirement for this to work is to enable [Allow edits from maintainers](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) option in your PR. Also the update will not work if your fork is located in an organization, not under your personal profile.
       Thanks 😄

@Souvikns
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 7d9df54 into asyncapi:master Jul 12, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

@Souvikns Souvikns mentioned this pull request Jul 16, 2024
Closed
@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shurtu-gal Shurtu-gal Shurtu-gal approved these changes

@Souvikns Souvikns Souvikns approved these changes

@Amzani Amzani Amzani approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
bounty AsyncAPI Bounty program related label ready-to-merge released
Projects
Bounty Program
Status: Completed
CLI - Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create create-template in AsyncAPI organization
6 participants
@AayushSaini101 @Amzani @asyncapi-bot @Souvikns @aeworxet @Shurtu-gal