Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make analytics config file's path configurable #1451

Merged

Conversation

peter-rr
Copy link
Member

@peter-rr peter-rr commented May 27, 2024

This PR will allow us to make the storage of .asyncapi-analytics config file configurable.

Related issue(s)
Relates to #1427

cc @smoya @fmvilas

@peter-rr peter-rr marked this pull request as ready for review June 3, 2024 10:07
@Shurtu-gal
Copy link
Collaborator

However, as I recommended in the Slack thread you shared, the best way to work with tests is to create an interface for the storage of the config, and swap it in tests (from in file, to in memory).

Will we be doing this as well?

@peter-rr
Copy link
Member Author

peter-rr commented Jun 3, 2024

However, as I recommended in the Slack thread you shared, the best way to work with tests is to create an interface for the storage of the config, and swap it in tests (from in file, to in memory).

Will we be doing this as well?

👍 Yeah, I've opened another PR to cover the changes related to tests: #1452

Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@peter-rr
Copy link
Member Author

peter-rr commented Jun 4, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 0909db9 into asyncapi:master Jun 4, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants