chore: use node-fetch instead of request
#1422
Conversation
helios2003
requested review from
Souvikns,
Amzani,
Shurtu-gal and
asyncapi-bot-eve
as code owners
|
/update |
scripts/fetch-asyncapi-example.js
Outdated
| console.log('Fetched ZIP file'); | ||
| resolve(); | ||
| }).on('error', reject); | ||
| fetch(SPEC_EXAMPLES_ZIP_URL) |
There was a problem hiding this comment.
Error handling can be improved by wrapping by a try/catch block (see: https://github.com/node-fetch/node-fetch?tab=readme-ov-file#handling-exceptions)
scripts/fetch-asyncapi-example.js
Outdated
| } | ||
| const file = fs.createWriteStream(TEMP_ZIP_NAME); | ||
| res.body.pipe(file); | ||
| file.on('close', () => { |
There was a problem hiding this comment.
Listen also the the error event
file.on('error', (err) => {
reject(err);
});
…into request-to-fetch
|
Done with the changes @Amzani |
|
Also, currently, we are using |
helios2003
changed the title
node-fetch insted of requestnode-fetch instead of request
|
|
/rtm |
|
🎉 This PR is included in version 1.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Using
node-fetchlibrary instead ofrequestsince the latter is deprecated.Related issue(s)
Fixes #1421