Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Dockerfile with python and .gyp to support install and run of Glee project in container #1208
fix: update Dockerfile with python and .gyp to support install and run of Glee project in container #1208
Changes from 7 commits
58def5f
6d5dbf2
77c8bc7
72aa407
af534fd
2e79ad6
1ff4056
19d69fb
e2119d0
e6f62ac
f2d42ce
6a9ac4c
da26884
d0b5269
6d518f2
8835147
50f2b38
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eelcofolkertsma you added
ASYNCAPI_CLI_VERSION
back in line 4 but it is still missing here - basically not usedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fixed that one too
If you use Dockerfile without change you get latest version of cli. If you add a version-value you get image for that version of cli
Tested OK in Github codespaces (default version=1.7.3, forced version=1.7.2) with docker build -t cli . and docker run cli --version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we need a
compose.yaml
committed in the repo.If it's needed I suggest to rename it to
docker-compose.yaml
To be confirmed by current maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do use the file in testing the viability of docker container (studio, glee), but test is far from trivial. I am very open to other test approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File has been renamed as per suggestion and moved to location ./test/manual
Comment in Dockerfile has been adjusted accordingly (instructions for testing)