fix: exit with 1 for failing validations #1068
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
While the implementation should be straight-forward, the tests somehow fail and report |
JarnoRFB
changed the title
JarnoRFB
requested review from
Souvikns,
magicmatatjahu,
derberg and
asyncapi-bot-eve
as code owners
|
Test are all green locally now, so this would be ready to review. |
|
|
@Souvikns @magicmatatjahu @derberg is there anything I should do to proceed with the PR? |
|
/rtm |
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Exit the
validatewith 1 for failing validations. Failing validations should exit with code 1 so they can be used in CI and also comply with the commands' documentation.Related issue(s)
Resolves #861