Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix up links #239

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: fix up links #239

merged 2 commits into from
Jan 30, 2024

Conversation

GreenRover
Copy link
Collaborator

Description

  • fix up broken links at mqtt binder

@GreenRover
Copy link
Collaborator Author

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @GreenRover! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

fmvilas
fmvilas reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get rid of the extra formatting changes? It's really hard to review like this 😅

@GreenRover
Copy link
Collaborator Author

@fmvilas sorry, my ide meant it too well

@GreenRover
Copy link
Collaborator Author

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @GreenRover! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@GreenRover
Copy link
Collaborator Author

/au

fmvilas
fmvilas approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@GreenRover
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit a6f931e into asyncapi:master Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
autoupdate ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GreenRover @asyncapi-bot @fmvilas