Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate from tslint to eslint #996

Merged
merged 12 commits into from
Apr 24, 2024

Conversation

kennethaasan
Copy link
Contributor

@kennethaasan kennethaasan commented Apr 23, 2024

Description

Changes proposed in this pull request:

  • migrate from tslint to eslint

Related issue(s)

See also #891

@kennethaasan kennethaasan changed the title chore: migrate from tslint to eslint feat: migrate from tslint to eslint Apr 23, 2024
@kennethaasan kennethaasan marked this pull request as ready for review April 23, 2024 13:22
@kennethaasan
Copy link
Contributor Author

kennethaasan commented Apr 23, 2024

@derberg, please review. I know it's a lot of changes, but it's kind of necessary in this PR. About 50% of the changes comes from --fix with eslint. I added some strict TS rules because this repo has way too much use of any. That should be the exception and not the norm.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member

derberg commented Apr 23, 2024

lgtm, just thinking if we really need a release, refactor: should be fine imho

@kennethaasan kennethaasan changed the title feat: migrate from tslint to eslint refactor: migrate from tslint to eslint Apr 23, 2024
@kennethaasan
Copy link
Contributor Author

@derberg, I was unsure myself. Let's do refactor

@derberg
Copy link
Member

derberg commented Apr 24, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit b9c167d into asyncapi:master Apr 24, 2024
16 checks passed
@kennethaasan kennethaasan deleted the eslint branch April 24, 2024 07:10
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.4.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants