Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve if-else code in server.ts #814

Merged
merged 1 commit into from
Oct 12, 2023
Merged

refactor: improve if-else code in server.ts #814

merged 1 commit into from
Oct 12, 2023

Conversation

parasss19
Copy link
Contributor

Description

Changes proposed in this pull request:

  • When using nested if statements, it can be difficult to keep track of the logic and understand the flow of the code. Using else if makes the code more concise and easier to follow.
Screenshot 2023-10-04 120148

Related issue(s)
#786

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@parasss19
Copy link
Contributor Author

Hey @derberg this is my new PR for the issue #786
I close the old PR #806 due to some conflicts

derberg
derberg approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@derberg derberg changed the title refactor: if-else statement code refactor: improve if-else code in server.ts Oct 12, 2023
@derberg
Copy link
Member

derberg commented Oct 12, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 9e49741 into asyncapi:master Oct 12, 2023
23 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasss19 @derberg @asyncapi-bot