refactor: add an optional chain instead of an expression check #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syedzubeen
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
|
@syedzubeen Thanks for the PR. When you contribute to any project, especially open source, you should open a PR only once you are familiarized with contributing guide like https://github.com/asyncapi/asyncapi-react/blob/master/CONTRIBUTING.md
|
syedzubeen
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
Updated. |
derberg
requested changes
Oct 16, 2023
There was a problem hiding this comment.
please check out linter complains
> lint
> tslint -c ./tslint.json --project tsconfig.base.json --format verbose && prettier --check "**/*.{ts,tsx,js,jsx,json,html,css,yaml}"
Checking formatting...
library/src/containers/Messages/MessageExample.tsx
Code style issues found in the above file(s). Forgot to run Prettier?
Error: Process completed with exit code 1.
|
closing as no followup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Added an optional chain instead of an expression check
Related issue(s)
Fixes #779