Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support protobuf #759

Closed
wants to merge 1 commit into from

Conversation

GreenRover
Copy link
Contributor

This is a spinn of from #758

Because in this project there was package-lock.js in format 1 and 2 i have had trouble to find the nodejs version to create only minimal changes. Hop this works for you.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GreenRover
Copy link
Contributor Author

anyone an idea why test are failing?

@derberg
Copy link
Member

derberg commented Sep 11, 2023

random issue caused by outdated CI/CD workflows.

does it make sense to make this change directly in master? Especially that looks like all codeowners support #761

@derberg
Copy link
Member

derberg commented Sep 28, 2023

next will soon be deleted. It is already merged into master and 1.0 is now available.

no more long living release branches!

I don't think we need this PR anymore

@derberg derberg closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants