Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration to use channel addresses in the sidebar for AsyncAPI v3 #1022

Conversation

diegotorresd
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Adds a configuration useChannelAddressAsIdentifier to the sidebar configuration, so that the channel address is used as a fallback also for AsyncAPI v3 documents. This helps maintain consistent UI when migrating from V2 to V3.

Related issue(s)

Fixes #1018

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@diegotorresd diegotorresd changed the title Add configuration to use channel addresses in the sidebar for AsyncAPI v3 feat: Add configuration to use channel addresses in the sidebar for AsyncAPI v3 Jun 26, 2024
@diegotorresd diegotorresd changed the title feat: Add configuration to use channel addresses in the sidebar for AsyncAPI v3 feat: add configuration to use channel addresses in the sidebar for AsyncAPI v3 Jun 26, 2024
@diegotorresd diegotorresd force-pushed the use-channel-address-in-sidebar-for-v3 branch from 9add575 to 2d9d622 Compare June 26, 2024 11:13
Copy link

sonarqubecloud bot commented Jul 3, 2024

@ibishal
Copy link

ibishal commented Jul 12, 2024

LGTM

Thanks for your contribution @diegotorresd

Comment on lines 60 to 61
`useChannelAddressAsIdentifier` uses the channel address or operation summary in the sidebar instead of the operationId, for both AsyncAPI v2 and v3 documents.
The default behaviour is to do this only for v2 documents.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`useChannelAddressAsIdentifier` uses the channel address or operation summary in the sidebar instead of the operationId, for both AsyncAPI v2 and v3 documents.
The default behaviour is to do this only for v2 documents.
`useChannelAddressAsIdentifier` for AsyncAPI v3 documents, use the operation summary or channel address in the sidebar instead of the operationId. By default, this behavior is applied only to AsyncAPI v2 documents..

small suggestion for docs, the rest is great, so just please apply this suggestion and we can merge

Copy link

@derberg
Copy link
Member

derberg commented Jul 25, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit f1978c4 into asyncapi:master Jul 25, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide config to show channel addresses as operation names in the sidebar for AsyncAPI v3 documents
4 participants