Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: improve out-of-date message on PRs + some other minor issues #156

Merged
merged 3 commits into from
Apr 20, 2022
Merged

ci: improve out-of-date message on PRs + some other minor issues #156

merged 3 commits into from
Apr 20, 2022

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Apr 15, 2022 •
edited
Loading

Description

fixes #158

@KhudaDad414 KhudaDad414 marked this pull request as ready for review April 19, 2022 18:00
@derberg derberg mentioned this pull request Apr 20, 2022
Closed
@derberg
Copy link
Member

derberg commented Apr 20, 2022

could you also, in this PR start using new SLACK_CI_FAIL_NOTIFY secret for:

🙏🏼

@KhudaDad414 KhudaDad414 changed the title ci: improve out-of-date message on PRs ci: improve out-of-date message on PRs + some other minor issues Apr 20, 2022
@KhudaDad414
Copy link
Member Author

@derberg made the changes.

derberg
derberg approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 :shipit:

@KhudaDad414
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 56ec03b into master Apr 20, 2022
@asyncapi-bot asyncapi-bot deleted the mergable-check branch April 20, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@quetzalliwrites quetzalliwrites Awaiting requested review from quetzalliwrites

@fmvilas fmvilas Awaiting requested review from fmvilas

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
autoupdate ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False negatives in local links
3 participants
@KhudaDad414 @derberg @asyncapi-bot