Add Wayland support and rework key finding #175
Conversation
|
This doesn't work for me. I'm using Hyprland (you cannot use it in VM without a GPU pass through). Here's an error log: There seem to be two issues:
|
|
@kamack38 What about changing keyboard layout using super + space or another shortcut? Does it works? You can test it like I did French BEPO keyboard layout + EN keyboard layout and test whether works character |
@kamack38 This environment variable Is not set why, do you know? This environment variable is in fact set which is why this error is strange. |
Super+space doesn't change the keyboard layout on Wayland which is why we shouldn't rely on shortcuts to do such things. It would be better if we find a way to do this programmatically |
You write that like it is a known thing. Can you send me a link to doc or something why? Because when I change the layout in settings (I do not know what is different between changing the layout in the settings and in the top menu, it sounds to me like the distro top menu is (I tested only Ubuntu 22.04) not wayland ready more than it is not sent on purpose) then I receive event active keyboard has been changed to EN or to FR BEPO. |
|
@kamack38 Could you please test that again with fix |
|
Issues I'm currently facing:
|
|
Anyway, could you please test if the EDIT: |
|
The |
Agree, thank you for mentioning that, now should be committed that keymap is created at driver start and keys are enabled and the same happens every time when is delivered new keymap.
What was already committed - more above - should I hope fix this. |
Is disabled because of an error inside the code? Can you please post here an error? |
Do you get this error only using service or even when you directly run python code? |
|
@kamack38 Please try to bind to something else and press and look whether was handler called. To do that start driver code using VSCode and put breakpoint here |
When I run the code directly. |
|
|
On the first run I also get this: |
|
I was told that using libxkbcommon one can get a keysym corresponding to the keycode, but I'm using the python library and I can't get it to work (changing layouts doesn't change the keysym produced). |
|
@kamack38 Can you post here link to .iso of your distro? I will try run that inside virtual box too, only what Is missing inside virtual box I guess and I have had no time yet discovery if Is possible Is how share I2C devices with virtual box instances. I have never tried Hyprland. But that error Is weird, it has to be something stupid because it Is required environment variable for Wayland and you have that variable even set up like you said. |
|
Problem with activation NumberPad without loaded keymap yet thought wayland I solved by predefining |
Co-authored-by: Kamack38 <[email protected]>
|
@kamack38 I have implemented dynamic findings for modifiers obtained thought Wayland with the workaround mentioned here and now I do not know about any problems so I request again branch to review. I found and fixed a few essential bugs so I think it is on the right way to be merged soon. Thank you! |
I have a little trouble understanding you here. Does this mean that changing the keyboard layout inside Gnome does not actually change the layout reported by |
|
@ldrahnik Have You tested the newest version, because I'm getting the following error using pyinotify |
Which version of Python do you use? ( |
I think the same but I did not search for opened issues. Anyway, I had two options, force to users of NumberPad to overbind shortcut for changing keyboard e.g. Super+Space with own script to use |
Please create separated issue in case it affects the master branch. |
|
@kamack38 Merged. Thank you for reviewing. You had a lot of useful points. |
No description provided.