Kafka exception catch #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OAUTHBEARER / OpenID Connect (OIDC) support as described in [KIP-768]. This is the authentication mechanism used by the GCN/TACH Kafka broker. * The `SASLMethod` enum gets a new member, `OAUTHBEARER`. * The `SASLAuth` constructor gets a new optional keyword argument, `token_endpoint`. * The presence of the `token_endpoint` keyword argument causes the default SASL method to change to `OAUTHBEARER` and the oauthbearer method to change to `oidc`, because this option is required for OpenID Connect and ignored for all other auth methods. * In OIDC mode, the `username` and `password` positional arguments are interpreted as the client ID and client secret. [KIP-768]: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186877575
This reverts commit 2dbb9ce.
cnweaver
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
I think that this is a useful change: With it in place if there is a network disruption, the broker goes down, etc. the consumer will keep retrying, which if the problem is resolved allows it to pick up reading where it left off (particularly with use of a consumer group). It is something of a blunt instrument, in that it does not give the user/higher level code the option to assess the error and decide whether to continue, but I think that such a capability probably isn't needed? This may be an area to keep an eye on in future, in case there are some types of errors which should break out of the subscribe loop and bubble up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #54.
It simply moves the consume call inside the try block in the _stream_forever method of the Consumer Class.
This allow the the main thread of the calling program to continue.