-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle case when triggered event is a manual workflow_dispatch #97
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking this up, highly appreciate it 👏
Have we tried out new changes manually? If not, could we do that, and add the result to the PR description?
You could point to this deploy-action branch in the GitHub workflow by specifying the deploy action reference, ex: uses: astronomer/deploy-action@fix/94
Apart from that, I left some minor comments to keep things clean.
GITHUB_EVENT_BEFORE=${{ github.event.before }} | ||
GITHUB_EVENT_AFTER=${{ github.event.after }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse these variables for the rest of the logic in this step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking time to review. :-) Addressed.
GITHUB_EVENT_BEFORE=${{ github.event.before }} | ||
GITHUB_EVENT_AFTER=${{ github.event.after }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse these variables for the rest of the logic in this step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
action.yaml
Outdated
# case when the triggered event is a manual workflow dispatch, we would need to deploy the dbt project because we cannot determine that it does not need to be deployed | ||
GITHUB_EVENT_BEFORE=${{ github.event.before }} | ||
GITHUB_EVENT_AFTER=${{ github.event.after }} | ||
if [[ -z $GITHUB_EVENT_BEFORE && -z $GITHUB_EVENT_AFTER ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could we club both the if
clause (this and the one below) into a single clause to avoid code repetition :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
action.yaml
Outdated
# case when the triggered event is a manual workflow dispatch, we would need to deploy the image because we cannot determine that it does not need to be deployed | ||
GITHUB_EVENT_BEFORE=${{ github.event.before }} | ||
GITHUB_EVENT_AFTER=${{ github.event.after }} | ||
if [[ -z $GITHUB_EVENT_BEFORE && -z $GITHUB_EVENT_AFTER ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could we club both the if
clause (this and the one below) into a single clause to avoid code repetition :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
Co-authored-by: Saketh Somaraju <[email protected]>
Fix #94 and #91
Added support to perform "Image Deploy" incase of
manual_dispatch
github event.