You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using v0.8.0, we're seeing an issue where nothing actually gets deployed even though the GH action succeeds. From what I can tell, it looks like the SKIP_IMAGE_OR_DAGS_DEPLOY value is never set to false, so the deploy step is skipped. In the logs I see an empty files changed: line, even though there should be changes (sometimes normal DAG changes within the dags/ folder and other times non-dag changes).
We are triggering this action from a workflow dispatch call, usually just against the master branch.
However, we have also triggered the action from a merged PR and I’m seeing the same issue.
On the other hand, if the action is triggered from a pushed branch, then the deploy is successful (both DAG-only deploys, and full-image deploys).
The only parameters we're passing are the deployment-id and a description.
The text was updated successfully, but these errors were encountered:
Create a new deployment in astro. Create API_TOKEN with deployment admin for the same deployment.
create github secrets with deployment ID and deployment token with keys ASTRO_DEPLOYMENT_ID andASTRO_API_TOKEN respectively.
create a new GitHub repository and clone it.
Add the following workflow in .github/workflows/deploy.yml
name: "[Manual Trigger] - Deploy to Production"
run-name: Deploy '${{ github.ref_name }}' to Prod
on:
workflow_dispatch:
env:
ASTRONOMER_SKIP_PARSE: true
concurrency:
group: ${{ github.workflow }} # group at the workflow level
jobs:
verify_valid_ref:
runs-on: ubuntu-latest
steps:
- name: Check that REF is either the master branch or a version tag
run: |
REF=${{ github.ref }}
echo "Selected REF: $REF"
if [[ "$REF" == "refs/heads/main" || "$REF" =~ ^refs/tags/v[0-9]+$ ]]; then
echo "Selected REF is valid: $REF"
else
echo "Invalid REF: $REF"
exit 1
fi
deploy:
needs: verify_valid_ref
if: success()
environment: production
runs-on: ubuntu-latest
env:
ASTRO_API_TOKEN: ${{ secrets.ASTRO_API_TOKEN }}
steps:
- name: Set Deployment Version
run: |
REF_NAME=${{ github.ref_name }}
if [[ "$REF_NAME" == "master" ]]; then
echo "VERSION=master (latest version)" >> $GITHUB_ENV
else
echo "VERSION=$REF_NAME" >> $GITHUB_ENV
fi
- name: Deploy to Astro
uses: astronomer/[email protected]
with:
deployment-id: ${{ secrets.ASTRO_DEPLOYMENT_ID }}
description: "@${{ github.actor }} deployed ${{ env.VERSION }}"
Perform astro dev init in the same repository.
Commit and push to the remote repository.
Trigger the workflow.
The workflow succeeds, but the deployment is not updated. The workflow log shows files changed: as blank, although files are updated.
Using v0.8.0, we're seeing an issue where nothing actually gets deployed even though the GH action succeeds. From what I can tell, it looks like the SKIP_IMAGE_OR_DAGS_DEPLOY value is never set to false, so the deploy step is skipped. In the logs I see an empty
files changed:
line, even though there should be changes (sometimes normal DAG changes within the dags/ folder and other times non-dag changes).We are triggering this action from a workflow dispatch call, usually just against the master branch.
However, we have also triggered the action from a merged PR and I’m seeing the same issue.
On the other hand, if the action is triggered from a pushed branch, then the deploy is successful (both DAG-only deploys, and full-image deploys).
The only parameters we're passing are the
deployment-id
and adescription
.The text was updated successfully, but these errors were encountered: