Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgres pod status check for k8s tests in CI #1320

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

pankajkoti
Copy link
Contributor

@pankajkoti pankajkoti commented Nov 13, 2024

It appears we have a flaky Kubernetes test that failed in PR #1313. As shown in the error log here, the PostgreSQL pod did not reach the ready state and instead entered an error status. Since the cause of the error status is unclear, this PR introduces a status check for the PostgreSQL pod to ensure it becomes fully running and healthy. If the pod enters an ERROR state, we now run a kubectl describe command on the pod to capture the event logs for debugging. The test will also exit with an error code of 1 to prevent further execution.

related: #1319

Copy link

cloudflare-workers-and-pages bot commented Nov 13, 2024

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: a54df5f
Status: ✅  Deploy successful!
Preview URL: https://21776618.astronomer-cosmos.pages.dev
Branch Preview URL: https://test-kubernetes-test.astronomer-cosmos.pages.dev

View logs

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (2b21f4c) to head (a54df5f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1320   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          67       67           
  Lines        3983     3983           
=======================================
  Hits         3818     3818           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajkoti pankajkoti changed the title Test k8s tests Add postgres pod status check for k8s tests in CI Nov 13, 2024
@pankajkoti pankajkoti marked this pull request as ready for review November 13, 2024 13:10
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. area:ci Related to CI, Github Actions, or other continuous integration tools execution:kubernetes Related to Kubernetes execution environment labels Nov 13, 2024
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks a lot, @pankajkoti ! Crossed fingers this will solve the issue.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@pankajkoti pankajkoti merged commit 92330f5 into main Nov 13, 2024
65 checks passed
@pankajkoti pankajkoti deleted the test-kubernetes-test branch November 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Related to CI, Github Actions, or other continuous integration tools execution:kubernetes Related to Kubernetes execution environment lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants