work in progress #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change DiscSimulations.jl/src/burgers/trixi.jl Lines 10 to 12 in bacf049 to using ..DiscSimulations: DiscSolution, OneDimension |
fjebaker
reviewed
Apr 19, 2023
|
|
||
| ##need to add functype constructors?? | ||
| using TruncatedStacktraces | ||
| TruncatedStacktraces.VERBOSE[] = true |
|
DiscSimulations.jl/src/DiscSimulations.jl Line 25 in aade215 Need to forward parameters here. |
fjebaker
reviewed
Apr 27, 2023
Python Burgers example/__pycache__/benchmarkedBurgers.cpython-310.pyc
Outdated
Show resolved
Hide resolved
fjebaker
reviewed
Apr 27, 2023
fjebaker
reviewed
May 2, 2023
examples/burger-chef.jl
Outdated
| simple_sol = | ||
| @time solve(simple_problem, Rodas5(autodiff = false); reltol = 1e-7, abstol = 1e-7) | ||
|
|
||
| spectral_x, _, T, Ti, spectral_problem = BurgerSpectral.setup(N, xmax) | ||
| spectral_x, _, T, Ti, spectral_problem = BurgerSpectral.setup(N, xmax, initial_condition_burgers) |
There was a problem hiding this comment.
You need to create a wrapper function that makes the initial condition function formats compatible. BurgerSimple and BurgerSpectral both expect functions in the form of:
f(::AbstractArray)::AbstractArraywhereas your function is of the form
f(::AbstractArray)::NumberTo fix, define something like
function _wrap_init_conditions(f::Function)
function _wrapper(x)
map(x) do i
f(SVector(i))
end
end
endYou can then use this as
... = BurgerSpectral.setup(N, xmax, _wrap_init_conditions(initial_condition_burgers))
fjebaker
reviewed
May 2, 2023
There was a problem hiding this comment.
No need to commit *.pyc files :~)
There was a problem hiding this comment.
Damn I thought I'd added that to the git ignore I don't know why it didn't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.