Avoid showing negations of ranges in error messages #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
Jan 19, 2024
zanieb
commented
Jan 19, 2024
| write!( | ||
| f, | ||
| "{}", | ||
| PackageRange::compatibility(self.package, &set.complement()) |
There was a problem hiding this comment.
I actually don't think set is guaranteed to be a single segment here so the pull request title is misleading. Regardless, it seems better to use the complement than to negate a section. Worth keeping in mind when we start to see real-world errors.
zanieb
changed the title
Closes #980 # Conflicts: # crates/puffin/tests/pip_install_scenarios.rs
zanieb
force-pushed
the
zb/negation-single
branch
from
162eb7c to
da60e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #980