Add static assets to docs pages
#6951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Sep 2, 2024
| @@ -2,7 +2,7 @@ site_name: uv | |||
| theme: | |||
| name: material | |||
| logo: assets/logo-letter.svg | |||
| favicon: assets/favicon.svg | |||
| favicon: assets/favicon.ico | |||
There was a problem hiding this comment.
I guess we have to keep something here? I don't know if this will be used or the links in the override:
<link rel="icon" type="image/png" sizes="32x32" href="/static/favicon-32x32.png"/>
<link rel="icon" type="image/png" sizes="16x16" href="/static/favicon-16x16.png"/>
There was a problem hiding this comment.
It looks like this gets used.
charliermarsh
added a commit
to astral-sh/ruff
that referenced
this pull request
Sep 3, 2024
## Summary Same as astral-sh/uv#6951. Unfortunately we have to use a single favicon for the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR points the docs towards the static assets that we use for
astral.sh, so that we can use shared assets for the Ruff and uv docs.