Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .exe suffix to tool command execution on Windows #6683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add .exe suffix to tool command execution on Windows #6683

wants to merge 2 commits into from

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Aug 27, 2024 •
edited
Loading

Should close #6682

@zanieb zanieb added the bug Something isn't working label Aug 27, 2024
@zanieb zanieb force-pushed the zb/use-exe-on-windowss branch from 5ec4a29 to 77efce0 Compare August 27, 2024 12:11
@zanieb zanieb marked this pull request as draft August 27, 2024 12:11
@zanieb zanieb force-pushed the zb/use-exe-on-windowss branch 2 times, most recently from a9880ba to 550191c Compare August 27, 2024 12:37
@zanieb zanieb requested a review from charliermarsh August 27, 2024 12:58
@zanieb zanieb marked this pull request as ready for review August 27, 2024 12:58
@zanieb
Copy link
Member Author

zanieb commented Aug 27, 2024 •
edited
Loading

Needs validation on Windows and more explicit test coverage.

@konstin tested this and I added a test with coverage

@samypr100
Copy link
Collaborator

This wouldn't solve gimme-aws-creds's case right? As there's no exe's in scripts declaration.

@zanieb
Copy link
Member Author

zanieb commented Aug 28, 2024

I presume not yeah.

@zanieb zanieb force-pushed the zb/use-exe-on-windowss branch 2 times, most recently from 0efdf7c to 40cddd3 Compare August 28, 2024 16:08
@zanieb zanieb mentioned this pull request Aug 28, 2024
Merged
@zanieb zanieb force-pushed the zb/use-exe-on-windowss branch from 40cddd3 to fb0f73b Compare September 3, 2024 22:27
@zanieb zanieb mentioned this pull request Nov 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build pyproject-build.exe not provided
2 participants
@zanieb @samypr100