Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify packse find links urls #2969

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Unify packse find links urls #2969

merged 4 commits into from
Apr 11, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Apr 10, 2024

The sync scenarios script is broken, so i did the updates manually

$ ./scripts/sync_scenarios.sh
Setting up a temporary environment...
Using Python 3.12.1 interpreter at: /home/konsti/projects/uv/.venv/bin/python3
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate
  × No solution found when resolving dependencies:
  ╰─▶ Because docutils==0.21.post1 is unusable because the package metadata was inconsistent and you require docutils==0.21.post1, we can conclude that the requirements are unsatisfiable.

      hint: Metadata for docutils==0.21.post1 was inconsistent:
        Package metadata version `0.21` does not match given version `0.21.post1`

@konstin konstin added the internal A refactor or improvement that is not user-facing label Apr 10, 2024
@konstin konstin requested a review from zanieb April 10, 2024 15:14
@@ -24,6 +24,9 @@ use uv_interpreter::{find_requested_python, PythonVersion};
// Exclude any packages uploaded after this date.
pub static EXCLUDE_NEWER: &str = "2024-03-25T00:00:00Z";

pub const PACKSE_FIND_LINKS_URL: &str =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call it like BUILD_VENDOR_LINKS_URL to make it clearer whats in here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to document why it's useful too. I added this so we could use --index-url instead of --extra-index-url to prevent dependency confusion attacks against our test suite, but without vendoring build dependencies that will generally fail.

@charliermarsh
Copy link
Member

The sync scenarios script is broken

I can't reproduce this, any idea what's going on there?

@konstin
Copy link
Member Author

konstin commented Apr 10, 2024

The docutils source dist is inconsistent about its version number: https://inspector.pypi.io/project/docutils/0.21/ . Haven't checked yet where that breaks uv

@charliermarsh
Copy link
Member

Note that I changed / fixed this behavior last night: #2953. But why is your system using the source distribution?

@zanieb
Copy link
Member

zanieb commented Apr 10, 2024

I tested with the sync script in #2970

zanieb and others added 3 commits April 11, 2024 10:23
Fixes #2963 which did not include the change as intended.
@konstin konstin enabled auto-merge (squash) April 11, 2024 08:29
@konstin konstin merged commit c85c52d into main Apr 11, 2024
37 checks passed
@konstin konstin deleted the konsti/unify-packse-find-links branch April 11, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants