-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify packse find links urls #2969
Conversation
crates/uv/tests/common/mod.rs
Outdated
@@ -24,6 +24,9 @@ use uv_interpreter::{find_requested_python, PythonVersion}; | |||
// Exclude any packages uploaded after this date. | |||
pub static EXCLUDE_NEWER: &str = "2024-03-25T00:00:00Z"; | |||
|
|||
pub const PACKSE_FIND_LINKS_URL: &str = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call it like BUILD_VENDOR_LINKS_URL
to make it clearer whats in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to document why it's useful too. I added this so we could use --index-url
instead of --extra-index-url
to prevent dependency confusion attacks against our test suite, but without vendoring build dependencies that will generally fail.
I can't reproduce this, any idea what's going on there? |
The docutils source dist is inconsistent about its version number: https://inspector.pypi.io/project/docutils/0.21/ . Haven't checked yet where that breaks uv |
Note that I changed / fixed this behavior last night: #2953. But why is your system using the source distribution? |
I tested with the sync script in #2970 |
The sync scenarios script is broken, so i did the updates manually