add tests for versions with local segments #2022
Conversation
|
Note we should merge in packse first so they publish to PyPI and are discovered by tests |
BurntSushi
force-pushed
the
ag/local-tests
branch
from
eaef93b to
ea0d784
Compare
This improves our coverage for installing packages involving versions with local segments. ~~This PR also adds a new optional `expected.ignore` property. When it's true, it's expected that the scenario will be ignored in downstream tools. For example, if the scenario doesn't pass yet even though it is expected or desired to.~~ I've backed out the change to add `expected.ignore` to the schema, and instead opted to mark tests as skipped on `uv`'s end in astral-sh/uv#2022. This makes sense to me since this de-couples the current state of `uv` from packse scenarios.
|
All righty, so I've got the packse repo updated with tests for local versions, but (and I should have anticipated this), publishing to I'm not quite sure how to fix this, and I also don't know the implications of merging this PR when publishing to |
BurntSushi
force-pushed
the
ag/local-tests
branch
from
ea0d784 to
3653218
Compare
The packse workflow has been simplified somewhat. Particularly now that building dumps scenarios into the same directory that the index serves. So there's no need for a separate publish step.
These tests aren't passing yet, but we hope that at least some of them will one day.
This includes the new tests that stress versions with local segments. These tests were added to packse here: astral-sh/packse#132
BurntSushi
force-pushed
the
ag/local-tests
branch
from
3653218 to
67eaee3
Compare
|
@BurntSushi I can definitely look into this when I'm back, I'm interested in getting us using a local PyPI mirror for tests which would allow us to do things like this. In the meantime.. if you merge with broken PyPI uploads we'll spam PyPI retrying the upload every few hours. You could exclude these scenarios from the PyPI uploads somehow then rely on our public CodeArtifact proxy to test the scenarios in CI. I'm not sure if it's worth the effort though. |
- Now that `packse` is being published to PyPI we can install it from there. - Tweaks the tooling around scenario updates to manage a temporary virtual environment for you. - Makes use of a new index URL - Includes local version segment scenarios (supersedes #2022)
|
Should this be closed? |
|
Yep! |
|
Sweet. (For posterity, these got merged into main separately.) |
|
Done in #2256 |
While trying to fix #1855, I came up with a few tests that improve
our coverage of versions with local segments. Those tests were added
to packse here: astral-sh/packse#132
None of these tests pass yet, so they are marked as ignored.