-
Notifications
You must be signed in to change notification settings - Fork 947
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ignore Python 2 installations when querying for interpreters (#1905)
## Summary Fixes #1693 `uv` currently fails when a user has `python` 2 or older installed on their system without a `python3` or `python3.exe` on their path because the `get_interpreter_info.py` script fails executing (it uses some Python 3+ APIs). This PR fixes this by: * Returning an explicit error code in `get_interpreter_info` if the Python version isn't supported * Skipping over this error in `python_query` if the user requested ANY python version or a version >= 3. * Error if the user requested a Python 2 version. ## Test Plan Error if the user requests a legacy python version. ``` uv venv -p 2 × Python 2 or older is not supported. Please use Python 3 or newer. ``` Ignore any python 2 installation when querying newer python installations (using v4 here because I have python3 on the path and that takes precedence over querying python) ``` uv_interpreter::python_query::find_python selector=Major(4) 0.005541s 0ms DEBUG uv_interpreter::interpreter Detecting markers for: /home/micha/.pyenv/shims/python 0.059730s 54ms DEBUG uv_interpreter::python_query Found a Python 2 installation that isn't supported by uv, skipping. 0.059983s 54ms DEBUG uv_interpreter::interpreter Using cached markers for: /usr/bin/python × No Python 4 In `PATH`. Is Python 4 installed? ```
- Loading branch information
1 parent
73ed0f0
commit 829e147
Showing
4 changed files
with
49 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters