Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow backtracking to before a specific package #38

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Dec 16, 2024

This allows discarding a previously made decision if it turned out to be a bad decision, even if all options with this decision have not yet been rejected.

We allow attempting to backtrack on packages that were not decided yet to avoid the caller from making the duplicative check.

astral-sh/uv#8157

This allows discarding a previously made decision if it turned out to be a bad decision, even if all options with this decision have not yet been rejected.

We allow attempting to backtrack on packages that were not decided yet to avoid the caller from making the duplicative check.
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 6 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • backtracking_disjoint_versions (2.3 s)
  • backtracking_ranges (2 s)
  • backtracking_singletons (4.3 s)
  • large_case_u16_NumberVersion.ron (21.3 ms)
  • sudoku-easy (3.8 ms)
  • sudoku-hard (3.9 ms)

@konstin konstin merged commit 0a9ace7 into main Dec 16, 2024
6 checks passed
konstin added a commit that referenced this pull request Dec 20, 2024
This allows discarding a previously made decision if it turned out to be
a bad decision, even if all options with this decision have not yet been
rejected.

We allow attempting to backtrack on packages that were not decided yet
to avoid the caller from making the duplicative check.

astral-sh/uv#8157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant