scenarios: add tests for Requires-Python #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Jun 12, 2024
| [root] | ||
| requires_python = ">=3.10" | ||
| requires = [ | ||
| "a==1.0.0 ; python_full_version == '3.9b1'", |
There was a problem hiding this comment.
Should we be including the pre-release here? Seems like it complicates the scenario and we should have coverage for that separately.
There was a problem hiding this comment.
(I found it surprising that it was not the same as the python_version test)
There was a problem hiding this comment.
The reason why I used it was because python_full_version specifically allows it. So it seemed nice to test that aspect of it. But I can see how it's potentially testing more than one thing. I can split this apart.
There was a problem hiding this comment.
Ahh that makes sense. This seems better anyway. Thanks!
This tests the interaction between `Requires-Python` and marker expressions like `python_version` and `python_full_version`. In both of these tests, the `a` dependency should be completely ignored because its corresponding marker expression will never evaluate to true.
BurntSushi
force-pushed
the
ag/universal-requires-python
branch
from
7ff0c37 to
f559097
Compare
zanieb
approved these changes
Jun 12, 2024
BurntSushi
added a commit
to astral-sh/uv
that referenced
this pull request
Jun 12, 2024
BurntSushi
added a commit
to astral-sh/uv
that referenced
this pull request
Jun 12, 2024
BurntSushi
added a commit
to astral-sh/uv
that referenced
this pull request
Jun 12, 2024
BurntSushi
added a commit
to astral-sh/uv
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the interaction between
Requires-Pythonand markerexpressions like
python_versionandpython_full_version. In both ofthese tests, the
adependency should be completely ignored because itscorresponding marker expression will never evaluate to true.