fetch: don't do a shallow clone #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a test failure on current `main` where `packse fetch --ref 0.1.0` was failing. Namely, `packse fetch` does a shallow clone, which means not all tags are available. Since `0.2.0` has been tagged, the shallow clone only has the `0.2.0` tag available. It's not clear what the right fix is here. I assume it is non-ideal to have a deep clone here, but it's also not clear to me whether we want `packse fetch --ref 0.1.0` to always work. If so, then I think we probably need a deep clone? We can adjust this of course in the future, but I made this change to unblock CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a test failure on current
mainwherepackse fetch --ref 0.1.0was failing. Namely,packse fetchdoes ashallow clone, which means not all tags are available. Since
0.2.0hasbeen tagged, the shallow clone only has the
0.2.0tag available.It's not clear what the right fix is here. I assume it is non-ideal to
have a deep clone here, but it's also not clear to me whether we want
packse fetch --ref 0.1.0to always work. If so, then I think weprobably need a deep clone?
We can adjust this of course in the future, but I made this change to
unblock CI.