Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements for pypsa and amiris loader #509

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

maurerle
Copy link
Member

@maurerle maurerle commented Dec 4, 2024

We did have some problems with the Amiris and PyPSA loaders, which are about to be fixed in this PR.

This also fixes the deprecation warning in PyPSA.

When running a distributed simulation using MQTT, it helps to set_tcp_nodelay=true in the MQTT config to improve performance a lot.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.59%. Comparing base (1681b84) to head (06e453b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
assume/common/grid_utils.py 0.00% 5 Missing ⚠️
assume/markets/clearing_algorithms/redispatch.py 0.00% 3 Missing ⚠️
assume/common/outputs.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   76.53%   77.59%   +1.05%     
==========================================
  Files          51       50       -1     
  Lines        6874     6784      -90     
==========================================
+ Hits         5261     5264       +3     
+ Misses       1613     1520      -93     
Flag Coverage Δ
pytest 77.59% <41.17%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maurerle
Copy link
Member Author

maurerle commented Dec 6, 2024

This shows the actual power flows on the grid dashboard:
We should implement flows for redispatch and naive solution as well

demo-assume2--general-assume-nodal-view--nodalview.mp4

(Sequence done with grafanimate --scenario=demo.py:assume_grid --output=./animations --use-panel-events --headless and a demo.py file)

after running assume -s example_01d -c nodal_case -db "postgresql+psycopg2://assume:assume@localhost:5432/assume"

…sa versions

fixes for the specialized loaders
add set_tcp_nodelay for MQTT
@maurerle
Copy link
Member Author

maurerle commented Dec 9, 2024

this is ready for review now :)

This removes the nodal_pricing clearing as it does not solve correctly
for different priced loads and does not work with the pypsa loader
@nick-harder nick-harder merged commit 30fdd9e into main Dec 10, 2024
7 of 9 checks passed
@nick-harder nick-harder deleted the fix_loaders branch December 10, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants