This repository has been archived by the owner on Jan 1, 2024. It is now read-only.
Use correct variant and version in UUID #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another fork has also addressed this in a slightly different manner: L2G@17b6a9c |
hamiltop
force-pushed
the
conform_to_rfc4122
branch
from
62482a9 to
7ceb974
Compare
| @@ -320,7 +324,8 @@ def generate(format = :default) | |||
| clock & 0xFFFFFFFF, | |||
| (clock >> 32) & 0xFFFF, | |||
| ((clock >> 48) & 0xFFFF | VERSION_CLOCK), | |||
| @sequence & 0xFFFF, | |||
| (@sequence >> 8) & 0xBF | 0x80, | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #33 , the current implementation does not conform to https://www.ietf.org/rfc/rfc4122.txt with regards to version and variant.
This pull request corrects that by properly setting the variant and version.